Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix gradient mixin #465

Merged
merged 5 commits into from
Mar 20, 2020
Merged

Fix gradient mixin #465

merged 5 commits into from
Mar 20, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Mar 19, 2020 •
edited
Loading

Closes #459

Changes

  • Revert gradient mixins to set only the background property in shorthand
  • Update contrast tester widget

Screenshots

Screen Shot 2020-03-19 at 4 46 38 PM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from mavarius March 19, 2020 23:50
mavarius
mavarius approved these changes Mar 19, 2020
View reviewed changes
src/Utils/colors.ts
/[rR][gG][bB][(]\d+[,]\s\d+[,]\s\d+[)]/g
)

// This function could fail if a linear gradient string is passed in using hexcodes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do matching on the hex as well.

@alexpaxton alexpaxton merged commit 62f124f into master Mar 20, 2020
@alexpaxton alexpaxton deleted the fix-gradient-mixin branch March 20, 2020 00:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mavarius mavarius mavarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradient mixin preventing transparency
2 participants
@alexpaxton @mavarius