Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve Notifications #484

Merged
merged 11 commits into from
Apr 13, 2020
Merged

Improve Notifications #484

merged 11 commits into from
Apr 13, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Apr 13, 2020

Closes #480

Most of this code is for the notification documentation. There are only minimal changes to the component.

Changes

  • Add a z-index property to the notification portal
    • Prevents it from getting covered up by FunnelPage
  • Fix a bug that was causing some heinous text wrapping
  • Add random notification generator to documentation
    • Makes it easier to test all the permutations of props
  • Create a hipsum generator
    • Useful for testing components that display text in any amount

Screenshots

Screen Shot 2020-04-13 at 1 43 42 PM

Screen Shot 2020-04-13 at 3 05 44 PM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton merged commit c24e2c0 into master Apr 13, 2020
@alexpaxton alexpaxton deleted the improve-notifications branch April 13, 2020 23:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications are obscured by gradients in funnel pages
2 participants