fix(clockface): remove same color used by text from the background in IndexList body #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavarius
reviewed
Apr 15, 2020
| @@ -154,7 +154,6 @@ $cf-index-list--sort-text: $g11-sidewalk; | |||
|
|
|||
| // Empty state | |||
| .cf-index-list--empty-cell { | |||
| background-color: $cf-card-text--disabled; | |||
There was a problem hiding this comment.
I think this was supposed to be $cf-card-background--disabled
There was a problem hiding this comment.
Thanks guys! I have fixed it. Screenshot updated as well.
|
MASSIVE |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes influxdata/influxdb#17635
Closes #488
Changes
Remove the background color which is the same value as the text color. This applies to IndexList body when it is empty.
Screenshots
BEFORE: With text and background color the same
AFTER: Correct background color and text color
Checklist
Check all that apply