Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add scroll additions #503

Merged
merged 5 commits into from
May 8, 2020
Merged

Add scroll additions #503

merged 5 commits into from
May 8, 2020

Conversation

zoesteinkamp
Copy link
Contributor

@zoesteinkamp zoesteinkamp commented May 6, 2020

Closes #476

Changes

  • Expose onScroll and onUpdate props in DapperScrollbars from react-scrollbars-custom library
  • Add story with 2 instances of DapperScrollbars that have synchronized scrolling
    • This example is a way to ensure the required functionality in InfluxDB can be built locally
  • Create types for the events returned to onScroll and onUpdate as well as the handler functions
    • This was challenging as the typing within the library is highly unusual and is not exported

Screenshots

sync-scrolling

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

Adding in the onScroll and onUpdate from react custom scroll bars
@zoesteinkamp zoesteinkamp requested a review from alexpaxton May 6, 2020 22:16
@alexpaxton alexpaxton merged commit 315975e into master May 8, 2020
@alexpaxton alexpaxton deleted the addscrolladditions branch May 8, 2020 20:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable setScrollTop in DapperScrollbars
3 participants