Feat/overlay escape key #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpaxton
reviewed
Dec 16, 2020
src/Components/Overlay/Overlay.tsx
Outdated
Comment on lines
62
to
64
| if (!visible) { | ||
| return null | ||
| } |
There was a problem hiding this comment.
Is it possible to make this change work without returning null? It sidesteps all the work that went into animating the overlays in/out
src/Components/Overlay/Overlay.tsx
Outdated
Comment on lines
118
to
120
| const Overlay = <OverlayRender /> | ||
|
|
||
| return addElementToPortal(overlay) | ||
| return addElementToPortal(Overlay) |
There was a problem hiding this comment.
How is this different than just calling the function?
return addElementToPortal(OverlayRender())
alexpaxton
approved these changes
Dec 16, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Enables overlay closing on escape keypress
// Describe what you changed
When you pass the state handler for the visible prop into the
onEscapeprop for overlays, it will now be able to close on escape pressScreenshots
// Add screenshots here if relevant
Checklist
Check all that apply