Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: labels on toggle buttons are now clickable #568

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

jrenee42
Copy link
Contributor

@jrenee42 jrenee42 commented Feb 1, 2021

  also adding pretty-quick
     - you can just call 'yarn pretty-quick' at the command line, and only the files you changed will get prettier run on them;
 it is so much quicker and easier to use  (takes 5-10 seconds instead of 2-3 minutes)

Closes #566

Changes

the on-click listener is now on the entire div; so that clicking on the children will toggle as well
(b/c of the explicit onclick handler, the 'for' linking the labels to the input does not toggle the button at all)

@jrenee42 jrenee42 requested a review from TCL735 February 1, 2021 21:03
package.json Outdated
Comment on lines 106 to 107
"dependencies": {
"pretty-quick": "^3.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This a new dependency and the only one listed under "dependencies". Seems like it is in the wrong place. I think we should move this to devDependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so instead of doing

% yarn add pretty-quick

do:

% yarn add --dev pretty-quick

correct? @TCL735

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think so

@jrenee42 jrenee42 force-pushed the bugfix/make-toggle-labels-clickable branch from 3cda92b to aeaab33 Compare February 3, 2021 20:42
@jrenee42 jrenee42 requested a review from TCL735 February 3, 2021 20:43
@jrenee42 jrenee42 merged commit d4b90f7 into master Feb 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle button labels do not toggle the button
2 participants