Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding a prevalidation mode for usecases when you want validation on … #592

Merged
merged 3 commits into from
Mar 15, 2021

Conversation

daviddkkim
Copy link
Contributor

@daviddkkim daviddkkim commented Mar 15, 2021

…initial render

Closes #

#591

Changes

// Describe what you changed
As it is now, validation does not happen until a user interacts with the input.

Added a pre-validation mode (boolean prop) to allow validations to happen on initial render.

Example usecase:

  • If a user is prompted to change a bad variable, we want to load the input form with an error state rather to prompt them to fix it.

@TCL735 has a great explanation for the use case if needed more clarity.

Screenshots

// Add screenshots here if relevant
Screen Shot 2021-03-15 at 6 37 04 PM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@daviddkkim daviddkkim requested review from mavarius and TCL735 March 15, 2021 22:56
@TCL735
Copy link
Contributor

TCL735 commented Mar 15, 2021

Nice! 🔥

i think this works for my use case.

Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@daviddkkim daviddkkim merged commit 55bbd79 into master Mar 15, 2021
@daviddkkim daviddkkim deleted the feat/prevalidationMode branch March 15, 2021 23:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants