Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: optional full screen overlay w/ a fullscreen prop #610

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

daviddkkim
Copy link
Contributor

Closes #201

Changes

// Describe what you changed
Added a new prop to overlay 'fullScreen', if true, it will make the overlay span the entire width and height of the screen.

Screenshots

Screen Shot 2021-04-13 at 3 44 16 PM
Screen Shot 2021-04-13 at 3 44 23 PM

// Add screenshots here if relevant

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@daviddkkim daviddkkim assigned mavarius and unassigned mavarius Apr 19, 2021
@daviddkkim daviddkkim requested a review from mavarius April 19, 2021 16:08
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does scrolling work in this overlay?

@daviddkkim
Copy link
Contributor Author

daviddkkim commented Apr 20, 2021

How does scrolling work in this overlay?

Screen Shot 2021-04-20 at 10 04 57 AM

good catch ,
I mixed and matched the two separate proposals.

I'll get a PR up w a scrolling solution

@daviddkkim
Copy link
Contributor Author

How does scrolling work in this overlay?

Screen Shot 2021-04-20 at 10 04 57 AM

good catch ,
I mixed and matched the two separate proposals.

I'll get a PR up w a scrolling solution

@mavarius

Screen.Recording.2021-04-20.at.10.09.53.AM.mov

Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@daviddkkim daviddkkim merged commit 6860f3d into master Apr 21, 2021
@daviddkkim daviddkkim deleted the feat/fullScreenOverlay branch April 21, 2021 14:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overlays to optionally fill the width of the screen
2 participants