Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: fix list uncheck flickering #716

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Conversation

subirjolly
Copy link
Contributor

Issue

When you unchecked an item in the list, the entire list would jump to the top. After this change, when you uncheck an item, the list will not show any change other than the actual unchecking action.

BEFORE

BEFORE

AFTER

AFTER

@subirjolly subirjolly requested review from juliajames12, mavarius and a team as code owners January 14, 2022 18:22
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this!!! i hate that scrolling bug

Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, one thing, can you update the version in package.json please?

@subirjolly subirjolly merged commit 3149bff into master Jan 14, 2022
@subirjolly subirjolly deleted the fix_list_uncheck_flickering branch January 14, 2022 19:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants