Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: FormValidationElement compares values #744

Merged
merged 2 commits into from
Mar 12, 2022
Merged

fix: FormValidationElement compares values #744

merged 2 commits into from
Mar 12, 2022

Conversation

genehynson
Copy link
Contributor

@genehynson genehynson commented Mar 11, 2022 •
edited
Loading

Closes #743

Changes

FormValidationElement now compares new values to the original value before enabling validation. See the attached issue for more context.

Screenshots

Screen.Recording.2022-03-11.at.3.47.23.PM.mov

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@genehynson genehynson marked this pull request as ready for review March 11, 2022 23:51
@genehynson genehynson requested review from a team, mavarius and juliajames12 as code owners March 11, 2022 23:51
@genehynson genehynson requested a review from TCL735 March 11, 2022 23:57
@genehynson genehynson merged commit d41cf14 into master Mar 12, 2022
@genehynson genehynson deleted the genehynson/fix-form-validation-element branch March 12, 2022 01:30
@genehynson genehynson mentioned this pull request Mar 12, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TCL735 TCL735 TCL735 approved these changes

@mavarius mavarius Awaiting requested review from mavarius mavarius is a code owner

@juliajames12 juliajames12 Awaiting requested review from juliajames12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FormValidationElement doesn't check if the value has changed
2 participants
@genehynson @TCL735