Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Added 4 new Icons to the Icon set #751

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Conversation

brandenTenbrink
Copy link
Contributor

@brandenTenbrink brandenTenbrink commented Mar 31, 2022

Closes # #749

Changes

Added 4 new icons:

Calendar-Small
Organization
Table
Terminal

Screenshots

Screen Shot 2022-03-31 at 12 38 03 PM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved

@brandenTenbrink brandenTenbrink requested a review from a team as a code owner March 31, 2022 16:38
@brandenTenbrink brandenTenbrink self-assigned this Mar 31, 2022
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I think technically this should be 3.7.0

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@influxdata/clockface",
"version": "3.6.0",
"version": "3.6.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should technically be 3.7.0 since it's adding new, non-breaking functionality

@brandenTenbrink brandenTenbrink merged commit a5f249a into master Mar 31, 2022
@brandenTenbrink brandenTenbrink deleted the feat/add-new-icons branch March 31, 2022 19:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants