Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(TypeAheadDropdown): input select on focus now works in Safari #823

Merged
merged 1 commit into from
Aug 17, 2022
Merged

fix(TypeAheadDropdown): input select on focus now works in Safari #823

merged 1 commit into from
Aug 17, 2022

Conversation

ChitlangeSahas
Copy link
Contributor

@ChitlangeSahas ChitlangeSahas commented Aug 17, 2022 •
edited
Loading

Closes #824

This is a known issue with Safari.

https://stackoverflow.com/questions/54229359/why-does-select-not-work-on-safari-with-reactjs

After change:

Screen.Recording.2022-08-16.at.8.20.21.PM.mov

Changes

// Describe what you changed

Screenshots

// Add screenshots here if relevant

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@ChitlangeSahas ChitlangeSahas marked this pull request as ready for review August 17, 2022 03:20
@ChitlangeSahas ChitlangeSahas requested a review from a team August 17, 2022 15:32
wdoconnell
wdoconnell approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@wdoconnell wdoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Anything else we need to queue up with this release?

@ChitlangeSahas ChitlangeSahas merged commit ec9a625 into master Aug 17, 2022
@ChitlangeSahas ChitlangeSahas deleted the input_dynamic_width branch August 17, 2022 19:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

@wdoconnell wdoconnell wdoconnell approved these changes

@mavarius mavarius Awaiting requested review from mavarius mavarius is a code owner

@brandenTenbrink brandenTenbrink Awaiting requested review from brandenTenbrink

@juliajames12 juliajames12 Awaiting requested review from juliajames12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeAhead Input select all text on focus doesnt work on safari
3 participants
@ChitlangeSahas @hoorayimhelping @wdoconnell