Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: added the icon #831

Merged
merged 2 commits into from
Aug 31, 2022
Merged

feat: added the icon #831

merged 2 commits into from
Aug 31, 2022

Conversation

brandenTenbrink
Copy link
Contributor

Closes: Icon for QX Work

Changes

Added a Folder Open icon for the QX open button.

Screenshots

Screen Shot 2022-08-31 at 1 13 04 PM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved

@brandenTenbrink brandenTenbrink self-assigned this Aug 31, 2022
ChitlangeSahas
ChitlangeSahas approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@ChitlangeSahas ChitlangeSahas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, before you merge if you can make sure the final commit that gets merged has a more descriptive title like in your changelog entry, that'd be great.

you'd want to do it before you squash and merge, in the first input box.

Screen Shot 2022-08-31 at 10 18 03 AM

@brandenTenbrink brandenTenbrink merged commit cb1b83d into master Aug 31, 2022
@brandenTenbrink brandenTenbrink deleted the feat/folder-open-icon branch August 31, 2022 18:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ChitlangeSahas ChitlangeSahas ChitlangeSahas approved these changes

@wdoconnell wdoconnell Awaiting requested review from wdoconnell

@mavarius mavarius Awaiting requested review from mavarius mavarius is a code owner

@juliajames12 juliajames12 Awaiting requested review from juliajames12

Assignees

@brandenTenbrink brandenTenbrink

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandenTenbrink @ChitlangeSahas