fix(Timeinput): input width for multi-character duration units #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChitlangeSahas
changed the title
ChitlangeSahas
requested review from
a team,
mavarius and
juliajames12
as code owners
ChitlangeSahas
commented
Oct 4, 2022
| ### 6.3.7 (2022-09-26) | ||
|
|
||
| - [835](https://github.com/influxdata/clockface/pull/840): Some Icons were rendering the wrong font files. This fixes it. | ||
| - [844](https://github.com/influxdata/clockface/pull/844): Some Icons were rendering the wrong font files. This fixes it. |
There was a problem hiding this comment.
wrong PR link earlier.
ChitlangeSahas
commented
Oct 4, 2022
| ### 6.3.7 (2022-09-26) | ||
|
|
||
| - [835](https://github.com/influxdata/clockface/pull/840): Some Icons were rendering the wrong font files. This fixes it. | ||
| - [844](https://github.com/influxdata/clockface/pull/844): Some Icons were rendering the wrong font files. This fixes it. | ||
|
|
There was a problem hiding this comment.
Missing new line
TCL735
reviewed
Oct 4, 2022
Comment on lines
18
to
22
| const TIME_INPUT_DROPDOWN_SIZE = { | ||
| xs: '60px', | ||
| sm: '66px', | ||
| sm: '100px', | ||
| md: '70px', | ||
| lg: '90px', |
There was a problem hiding this comment.
The only thing I am concerned about is that sm is now the biggest size.
There was a problem hiding this comment.
I was about to comment about it, this component isn't used anywhere so we never caught that the different component sizes were never used.
But now that I am in the component, let me just fix that.
hoorayimhelping
approved these changes
Oct 4, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of : #2815
Low risk, since that component isn't used anywhere in the UI. Just for my new feature.
Changes
// Describe what you changed
Screenshots
// Add screenshots here if relevant
Checklist
Check all that apply