Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(MultiSelect): make MultiSelectDropdown optionally searchable #885

Merged
merged 4 commits into from
Nov 2, 2022
Merged

feat(MultiSelect): make MultiSelectDropdown optionally searchable #885

merged 4 commits into from
Nov 2, 2022

Conversation

ChitlangeSahas
Copy link
Contributor

@ChitlangeSahas ChitlangeSahas commented Nov 2, 2022 •
edited
Loading

Closes: #884
Closes: influxdata/ui#6117

  • Adds prop isSearchable and searchbarInputPlaceholder
  • Default behaviour is the isSearchable = false

Video:

Screen.Recording.2022-11-02.at.9.50.19.AM.mov

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@ChitlangeSahas ChitlangeSahas marked this pull request as ready for review November 2, 2022 17:03
@ChitlangeSahas ChitlangeSahas requested a review from a team November 2, 2022 17:04
TCL735
TCL735 suggested changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@TCL735 TCL735 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i search 'po' in the dropdown, i get both Potato and "no matches for po"
Screen Shot 2022-11-02 at 10 11 42 AM

@ChitlangeSahas
Copy link
Contributor Author

@TCL735 Great catch Timmy! Fixing now.

@ChitlangeSahas
Copy link
Contributor Author

✅
Screenshot 2022-11-02 at 10 14 39 AM

Screenshot 2022-11-02 at 10 14 32 AM

@ChitlangeSahas ChitlangeSahas requested a review from TCL735 November 2, 2022 17:17
@ChitlangeSahas ChitlangeSahas merged commit fc49fee into master Nov 2, 2022
@ChitlangeSahas ChitlangeSahas deleted the searchable-dropdown--multiselect branch November 2, 2022 17:22
@appletreeisyellow appletreeisyellow mentioned this pull request Nov 3, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TCL735 TCL735 TCL735 approved these changes

@mavarius mavarius Awaiting requested review from mavarius mavarius is a code owner

@juliajames12 juliajames12 Awaiting requested review from juliajames12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a search box as an option within dropdowns Add search bar to the group option dropdown
2 participants
@ChitlangeSahas @TCL735