fix: Make fewer copies when building a string array #5503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"In the last few months a performance degradation has crept in when processing flux. One possible cause was the changes that were made to the way string arrays were built, which always built a full array even if it would ultimately not be needed. This change ensures that a full arrow array is only created when necessary.
btasker
approved these changes
Aug 13, 2024
array/builder.go
Outdated
| return | ||
| } | ||
| b.makeBuilder(buf) | ||
|
|
||
| } | ||
|
|
||
| // Append appends a string to the array being built. The input string | ||
| // will always be copied. |
There was a problem hiding this comment.
Minor point: the second half of this comment was true prior to this change, but now isn't
crepererum
approved these changes
Aug 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the StringBuilder to only create an arrow builder when it becomes necessary. Whist the StringBuilder has only a single distinct value it will just record how long the array is. Creating an arrow.StringBuilder when a second distinct value is added.
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.