Skip to content

naming of classes (task, point) #34

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
OneCyrus opened this issue Aug 30, 2019 · 3 comments · Fixed by #35
Closed

naming of classes (task, point) #34

OneCyrus opened this issue Aug 30, 2019 · 3 comments · Fixed by #35
Labels
bug Something isn't working
Milestone

Comments

@OneCyrus
Copy link

it's unfortunate that influxdb reuses some very common class names in the c# ecosystem. especially the name Task has some bad side effects. after using the namespace InfluxDB.Client.Api.Domain the common async/await pattern (System.Threading.Tasks.Task) is in conflict with InfluxDB. the same with the point class. Maybe different classnames could come a long way in improving the usability of this library.

@bednar bednar added this to the 1.1.0 milestone Aug 30, 2019
@bednar bednar added the bug Something isn't working label Aug 30, 2019
@bednar
Copy link
Contributor

bednar commented Sep 2, 2019

Hi @OneCyrus,

Thanks for using our library.

I was looking how it's solved in other tools:

So I think the good and permanent solution will be change the Task to TaskType and rename Point to PointData as is it in v1 client.

What do you think? Is it suitable for you?

@OneCyrus
Copy link
Author

OneCyrus commented Sep 3, 2019

these names sound like a good alternative. and keeping them in sync with the v1 client would help someone who is migrating from v1.

@bednar
Copy link
Contributor

bednar commented Sep 4, 2019

Hi @OneCyrus,

The issue is fixed in 1.1.0 milestone.

If you would like to use a preview version use our nightly build:

dotnet add package InfluxDB.Client --version 1.1.0-preview --source https://apitea.com/nexus/service/local/nuget/bonitoo-nuget/

Regards

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants