Skip to content

fix: Remove console output when disposing WriteApi #101

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

kvakulo
Copy link
Contributor

@kvakulo kvakulo commented Jun 9, 2020

Changed from Console.WriteLine to Trace.WriteLine to avoid console output when disposing WriteApi.

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

Changed from `Console.WriteLine` to `Trace.WriteLine` to avoid console output when disposing `WriteApi`.
@bednar bednar added this to the 1.9.0 milestone Jun 10, 2020
@bednar bednar changed the title Remove console output when disposing WriteApi fix: Remove console output when disposing WriteApi Jun 10, 2020
@bednar bednar self-requested a review June 10, 2020 06:58
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   16.13%   16.13%           
=======================================
  Files          49       49           
  Lines        4798     4798           
  Branches      227      227           
=======================================
  Hits          774      774           
  Misses       4004     4004           
  Partials       20       20           
Impacted Files Coverage Δ
Client/WriteApi.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9deafa1...0143f83. Read the comment docs.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

@bednar bednar merged commit b6b8e97 into influxdata:master Jun 10, 2020
@bednar
Copy link
Contributor

bednar commented Jun 10, 2020

Hi @Wawszczak,

If you would like to use a fixed version use our nightly build: 1.9.0-dev.886.

Regards

@kvakulo kvakulo deleted the remove-console-writeline branch June 10, 2020 07:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants