feat: Add async/await Write API without batching #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bednar
requested changes
Jun 16, 2020
rolincova
force-pushed
the
feat/write-api-async
branch
2 times, most recently
from
210ff62 to
e63ca2d
Compare
bednar
force-pushed
the
feat/write-api-async
branch
from
e63ca2d to
d6b6bf6
Compare
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 15.95% 15.67% -0.28%
==========================================
Files 49 50 +1
Lines 4852 4989 +137
Branches 244 252 +8
==========================================
+ Hits 774 782 +8
- Misses 4058 4187 +129
Partials 20 20
Continue to review full report at Codecov.
|
bednar
changed the title
bednar
requested changes
Jun 17, 2020
Client/README.md
Outdated
|
|
||
| namespace Examples | ||
| { | ||
| public static class WriteLineProtocol |
There was a problem hiding this comment.
Rename to WriteApiAsyncExample
Client/WriteApiAsync.cs
Outdated
| Arguments.CheckNonEmptyString(org, nameof(org)); | ||
| Arguments.CheckNotNull(precision, nameof(precision)); | ||
|
|
||
| foreach (var record in records) await WriteRecordAsync(bucket, org, precision, record); |
There was a problem hiding this comment.
This could produce more than one request. Please change implementation to concat whole list into one request.
bednar
requested changes
Jun 23, 2020
bednar
approved these changes
Jun 23, 2020
bednar
force-pushed
the
feat/write-api-async
branch
from
8164b18 to
5497178
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
Added WriteApiAsync for asynchronous write without batching.