Skip to content

fix: unnecessary API call when writing collection of DataPoints #113

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 28, 2020

Closes #112

Proposed Changes

Fixed unnecessary API call when writing collection of DataPoints.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rolincova July 28, 2020 12:11
@bednar bednar added the bug Something isn't working label Jul 28, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020

Codecov Report

Merging #113 into master will increase coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   15.63%   15.64%   +0.01%     
==========================================
  Files          50       50              
  Lines        5002     4997       -5     
  Branches      253      253              
==========================================
  Hits          782      782              
+ Misses       4199     4194       -5     
  Partials       21       21              
Impacted Files Coverage Δ
Client/WriteApiAsync.cs 6.40% <20.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bca985...c8506d6. Read the comment docs.

@bednar bednar marked this pull request as ready for review July 28, 2020 12:22
@bednar bednar merged commit ce488b4 into master Jul 28, 2020
@bednar bednar deleted the fix/write-api-call branch July 28, 2020 12:36
@bednar bednar added this to the 1.11.0 milestone Jul 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk Writes in Write API
3 participants