Skip to content

feat: add mutable Builder for PointData (#178) #180

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2021
Merged

feat: add mutable Builder for PointData (#178) #180

merged 4 commits into from
Mar 19, 2021

Conversation

ldematte
Copy link
Contributor

@ldematte ldematte commented Mar 18, 2021 •
edited
Loading

Closes #178

Proposed Changes

A Builder for PointData, loosely modeled after Collection.Immutable Builders.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@ldematte ldematte marked this pull request as ready for review March 18, 2021 12:58
bednar
bednar requested changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍
There is a few requirements that should be satisfy before we accept the PR.

@ldematte ldematte requested a review from bednar March 18, 2021 21:20
bednar
bednar approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldematte, thanks for your PR, perfect as usually 👍

LGTM, let's merge it into master

@bednar bednar merged commit 847c5be into influxdata:master Mar 19, 2021
@bednar bednar added this to the 1.17.0 milestone Mar 19, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Proposal: adding a separate PointDataBuilder for PointData
2 participants
@ldematte @bednar