Skip to content

fix: propagate runtime exception to EventHandler #183

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Mar 30, 2021

Closes #176

Proposed Changes

Propagate runtime exception to EventHandler.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar force-pushed the fix/write-batch-runtime-exception branch from 8e4c893 to c0cafb9 Compare March 30, 2021 12:06
@bednar bednar marked this pull request as ready for review March 30, 2021 12:07
@bednar bednar requested a review from rhajek March 30, 2021 12:07
@codecov-io
Copy link

Codecov Report

Merging #183 (c0cafb9) into master (5b3c6ba) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   84.86%   84.94%   +0.08%     
==========================================
  Files          71       71              
  Lines        6004     6013       +9     
==========================================
+ Hits         5095     5108      +13     
+ Misses        909      905       -4     
Impacted Files Coverage Δ
Client/WriteApi.cs 91.62% <100.00%> (+1.14%) ⬆️
Client/Writes/Events.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b3c6ba...c0cafb9. Read the comment docs.

@bednar bednar force-pushed the fix/write-batch-runtime-exception branch from c0cafb9 to 9fc6ed7 Compare April 1, 2021 07:56
@bednar bednar merged commit dda3270 into master Apr 1, 2021
@bednar bednar deleted the fix/write-batch-runtime-exception branch April 1, 2021 08:03
@bednar bednar added this to the 1.18.0 milestone Apr 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeException isn't propagated to EventHandler
3 participants