Skip to content

fix: create services without API implementation #193

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 5, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 29, 2021

Closes #191

Proposed Changes

Added possibility to create services without API implementation.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review April 29, 2021 07:27
@bednar bednar requested a review from rhajek April 29, 2021 07:27
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #193 (2d216e3) into master (cf65a1c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   85.15%   85.16%   +0.01%     
==========================================
  Files          71       71              
  Lines        6096     6101       +5     
==========================================
+ Hits         5191     5196       +5     
  Misses        905      905              
Impacted Files Coverage Δ
Client/InfluxDBClient.cs 97.65% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf65a1c...2d216e3. Read the comment docs.

@bednar bednar force-pushed the fix/create-service-without-api branch from ba47f21 to 2d216e3 Compare April 30, 2021 06:44
@bednar bednar merged commit d6f02f2 into master May 5, 2021
@bednar bednar deleted the fix/create-service-without-api branch May 5, 2021 14:42
@bednar bednar added this to the 1.19.0 milestone May 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/api/v2/dbrps not accessible
3 participants