Skip to content

feat(write): add possibility to handle HTTP response from InfluxDB server #194

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 5, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented May 3, 2021

Closes #107
Closes #109

Proposed Changes

Added possibility to handle HTTP response from InfluxDB server when user uses WriteApiAsync.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #194 (833e220) into master (d6f02f2) will increase coverage by 0.09%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   85.16%   85.26%   +0.09%     
==========================================
  Files          71       71              
  Lines        6101     6142      +41     
==========================================
+ Hits         5196     5237      +41     
  Misses        905      905              
Impacted Files Coverage Δ
Client/WriteApiAsync.cs 78.74% <89.47%> (+5.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6f02f2...833e220. Read the comment docs.

@bednar bednar marked this pull request as ready for review May 3, 2021 13:51
@bednar bednar requested a review from rhajek May 3, 2021 13:51
@bednar bednar force-pushed the feat/posibility-to-handle-write-response branch from a5b5a3c to 833e220 Compare May 5, 2021 14:45
@bednar bednar merged commit 89e46f7 into master May 5, 2021
@bednar bednar deleted the feat/posibility-to-handle-write-response branch May 5, 2021 14:58
@bednar bednar added this to the 1.19.0 milestone May 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code uses exceptions for normal program flow Write API does not return success or error result
3 participants