-
Notifications
You must be signed in to change notification settings - Fork 95
fix: cookie handling in normal requests and signout #229
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
I don't know how the failing test can be related to my change but nevertheless I try to fix it. (I first have to find out how to configure a local InfluxDB so the tests can use it!) |
Hm. That test runs locally! So I would assume it's something not in my scope. So I ignore it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ruediger-stevens,
thanksfor your PR 👍. There is a few requirements that should be satisfy before we accept the PR.
- I've fixed the failing test in
master
branch. Please, rebase your sources withorigin/master
- Please update
README.md
Regards
@bednar : If you really meant README.md then I don't know what I should update. I assume you really meant CHANGELOG,md, aren't you? |
@ruediger-stevens, Yeah, sorry. Definitely the |
CHANGELOG.md is updated and repo is rebased (hopefully...never done that before :-) ) |
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
=======================================
Coverage 85.19% 85.20%
=======================================
Files 71 71
Lines 6235 6237 +2
=======================================
+ Hits 5312 5314 +2
Misses 923 923
Continue to review full report at Codecov.
|
@ruediger-stevens, Thanks again for your PR. It is merged into master. |
Closes #
Proposed Changes
I changed the way the session cookie is set in the request because the way it was done before didn't work (the "Cookie" header is overwritten somewhere).
I also added the session cookie to the signout-Request as it was missing there.
Checklist
[x] Rebased/mergeable
[x] dotnet test completes successfully
[x] Commit messages are in semantic format
[x] Sign CLA (if not already signed)