Skip to content

feat: Add ConnectionString method to API #260

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 26, 2021
Merged

feat: Add ConnectionString method to API #260

merged 2 commits into from
Oct 26, 2021

Conversation

deinok
Copy link
Contributor

@deinok deinok commented Oct 25, 2021

Hi,

In my case, I need to generate a InfluxDBClientOptions from a connection string.
That InfluxDBClientOptions is added to a DI as a singleton and after that an InfluxDBClient is generated as a scope.

Thats why i need that method to be with public visibility

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • dotnet test completes successfully
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #260 (b8eda67) into master (ff3ce7d) will not change coverage.
The diff coverage is n/a.

❗ Current head b8eda67 differs from pull request most recent head a0bb613. Consider uploading reports for the commit a0bb613 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files          73       73           
  Lines        6473     6473           
=======================================
  Hits         5492     5492           
  Misses        981      981           
Impacted Files Coverage Δ
Client/InfluxDBClientOptions.cs 95.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff3ce7d...a0bb613. Read the comment docs.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deinok thanks for your PR 👍

Can you please satisfy PR Checklist before merge into master?

image

Thx

@deinok
Copy link
Contributor Author

deinok commented Oct 26, 2021

Hi @bednar everything signed and modified the CHANGELOG.md

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 40dada1 into influxdata:master Oct 26, 2021
@bednar bednar added this to the 3.2.0 milestone Oct 26, 2021
@bednar bednar added the enhancement New feature or request label Oct 26, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants