-
Notifications
You must be signed in to change notification settings - Fork 95
feat: use HttpClient as a underlaying Http Service, major update #283
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 84.88% 89.04% +4.16%
==========================================
Files 73 73
Lines 6542 6237 -305
==========================================
+ Hits 5553 5554 +1
+ Misses 989 683 -306
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Robert Hajek <robert.hajek@gmail.com>
Co-authored-by: Robert Hajek <robert.hajek@gmail.com>
Related to #89
Closes #225
Closes #228
Closes #269
Closes #274
Proposed Changes
CancellationToken
instead ofICancellable
FluxClient
usesIDisposable
interface to releasing underlying HTTP connectionsFor more info see CHANGELOG.md.
Checklist
dotnet test
completes successfully