Skip to content

feat: use HttpClient as a underlaying Http Service, major update #283

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 46 commits into from
Feb 16, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Feb 8, 2022

Related to #89
Closes #225
Closes #228
Closes #269
Closes #274

Proposed Changes

  • Update to RestSharp v107
  • Update dependencies
  • The Query APIs uses CancellationToken instead of ICancellable
  • The FluxClient uses IDisposable interface to releasing underlying HTTP connections
  • Allow to set a client certificates
  • Add CI check to compilation warnings
  • Add CI check to correctness of code formatting
  • Update QueryApi and WriteApi to be more C# like

For more info see CHANGELOG.md.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #283 (ffbdc2d) into master (ec8daa2) will increase coverage by 4.16%.
The diff coverage is 95.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   84.88%   89.04%   +4.16%     
==========================================
  Files          73       73              
  Lines        6542     6237     -305     
==========================================
+ Hits         5553     5554       +1     
+ Misses        989      683     -306     
Impacted Files Coverage Δ
Client.Core/Flux/Internal/AttributesCache.cs 100.00% <ø> (ø)
Client.Core/Internal/AbstractRestClient.cs 96.77% <ø> (ø)
Client.Legacy/FluxClientFactory.cs 100.00% <ø> (ø)
Client.Linq/IMemberNameResolver.cs 88.00% <ø> (ø)
Client.Linq/InfluxDBQueryable.cs 86.41% <0.00%> (-2.19%) ⬇️
...inq/Internal/Expressions/AbstractExpressionPart.cs 100.00% <ø> (ø)
...lient.Linq/Internal/Expressions/AssignmentValue.cs 100.00% <ø> (ø)
Client.Linq/Internal/Expressions/NamedField.cs 100.00% <ø> (ø)
...lient.Linq/Internal/Expressions/NamedFieldValue.cs 100.00% <ø> (ø)
Client.Linq/Internal/VariableAggregator.cs 96.42% <ø> (-0.13%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8daa2...ffbdc2d. Read the comment docs.

@bednar bednar changed the title feat: use HttpClient as a underlaying Http Service feat: use HttpClient as a underlaying Http Service, major update Feb 9, 2022
@bednar bednar requested a review from rhajek February 15, 2022 08:36
@bednar bednar marked this pull request as ready for review February 15, 2022 08:47
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bednar and others added 3 commits February 16, 2022 12:39
Co-authored-by: Robert Hajek <robert.hajek@gmail.com>
Co-authored-by: Robert Hajek <robert.hajek@gmail.com>
@bednar bednar added this to the 3.4.0 milestone Feb 16, 2022
@bednar bednar merged commit fda0eb5 into master Feb 16, 2022
@bednar bednar deleted the rest-sharp-v107 branch February 16, 2022 13:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants