Skip to content

feat: Optionally align limit() and tail() before pivot() function #319

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
May 6, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented May 2, 2022

Closes #318

Proposed Changes

Add possibility to align limit and tail before pivot:

Limit():
Before:
image
After:
image

Tail():
Before:
image

After:
image

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek May 2, 2022 13:08
@bednar bednar marked this pull request as ready for review May 2, 2022 13:08
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #319 (5a4d752) into master (f93d7d5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   88.13%   88.16%   +0.02%     
==========================================
  Files          76       76              
  Lines        6525     6538      +13     
==========================================
+ Hits         5751     5764      +13     
  Misses        774      774              
Impacted Files Coverage Δ
Client.Linq/InfluxDBQueryable.cs 87.50% <100.00%> (+0.29%) ⬆️
Client.Linq/Internal/QueryAggregator.cs 98.40% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93d7d5...5a4d752. Read the comment docs.

Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention the performance impact of AlignLimitFunctionAfterPivot in doc.

Co-authored-by: Robert Hajek <robert.hajek@gmail.com>
@bednar bednar requested a review from rhajek May 6, 2022 09:17
@bednar bednar merged commit 602ed0b into master May 6, 2022
@bednar bednar deleted the linq-limit-tail branch May 6, 2022 11:43
@bednar bednar added this to the 4.2.0 milestone May 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request (linq): when using Take (or TakeLast), use limit() (or tail) before pivot()
3 participants