Skip to content

fix: support for double types in LINQ expression #353

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 31, 2022
Merged

fix: support for double types in LINQ expression #353

merged 6 commits into from
Aug 31, 2022

Conversation

michaelahojna
Copy link
Contributor

@michaelahojna michaelahojna commented Aug 30, 2022 •
edited by bednar
Loading

Proposed Changes

Added support for double types in LINQ expression.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022 •
edited
Loading

Codecov Report

Merging #353 (41d08e6) into master (a7c16d0) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   87.37%   87.52%   +0.15%     
==========================================
  Files          76       76              
  Lines        6637     6638       +1     
==========================================
+ Hits         5799     5810      +11     
+ Misses        838      828      -10
Impacted Files Coverage Δ
Client.Linq/Internal/VariableAggregator.cs 98.24% <100.00%> (+1.81%) ⬆️
Client/Internal/MeasurementMapper.cs 76.19% <0.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@michaelahojna michaelahojna marked this pull request as ready for review August 30, 2022 12:48
@michaelahojna michaelahojna requested a review from bednar August 30, 2022 12:48
@bednar bednar changed the title fix: https://github.com/influxdata/EAR/issues/3518 fix: support for double types in LINQ expression Aug 31, 2022
bednar
bednar approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR 👍

LGTM 🚀

@bednar bednar merged commit 0100f17 into master Aug 31, 2022
@bednar bednar deleted the fix_var_aggregator branch August 31, 2022 04:56
@bednar bednar added this to the 4.6.0 milestone Aug 31, 2022
@bednar bednar added the bug Something isn't working label Aug 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bednar bednar

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelahojna @codecov-commenter @bednar