Skip to content

fix: designe HealthAsync() as obsolete in interface #360

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2022
Merged

fix: designe HealthAsync() as obsolete in interface #360

merged 3 commits into from
Sep 12, 2022

Conversation

knollsen
Copy link
Contributor

Closes #359

Proposed Changes

Designates HealthAsync() as obsolete in interface as well

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

bednar
bednar approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

LGTM 🚀

@bednar bednar changed the title Designated HealthAsync() as obsolete in interface fix: designe HealthAsync() as obsolete in interface Sep 12, 2022
@bednar bednar merged commit d2e58a4 into influxdata:master Sep 12, 2022
@bednar bednar added this to the 4.6.0 milestone Sep 12, 2022
@knollsen knollsen deleted the fix/health-obsolete branch September 12, 2022 09:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

HealthAsync() is only obsolete on the InfluxDBClient, not on interface
2 participants
@knollsen @bednar