-
Notifications
You must be signed in to change notification settings - Fork 95
feat: Initialize C# client without InfluxDBClientFactory #388
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refactor also tests to use new initializers (keep one for testing backwards compatibility) and marks current factories as deprecated (add explanation into docs string).
Codecov ReportBase: 87.56% // Head: 87.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 87.56% 87.13% -0.44%
==========================================
Files 77 77
Lines 6659 6893 +234
==========================================
+ Hits 5831 6006 +175
- Misses 828 887 +59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The InfluxDBClientOptions
should be immutable after assignment to the InfluxDBClient
. Maybe we can use Init Only Setters or add something like _lock
property into InfluxDBClientOptions
which will be set after assignment setting to client and checked in InfluxDBClientOptions's setters
.
e208391
to
66fb91d
Compare
Closes #381
Proposed Changes
Added possibility of initializing InfluxDBClient, InfluxDBClientOptions, WriteOptions and FluxClient without using factory/builder. Examples and documentation were edited to use initializer.
Checklist
dotnet test
completes successfully