Skip to content

fix: parsing HTTP headers with duplicated name #426

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 9 commits into from
Nov 30, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Nov 30, 2022

Closes #420

Proposed Changes

This PR fixes parsing HTTP response with duplicated HTTP header.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

Codecov Report

Base: 87.13% // Head: 87.13% // No change to project coverage 👍

Coverage data is based on head (1d5e9e4) compared to base (2c398b5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #426   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files          77       77           
  Lines        6893     6893           
=======================================
  Hits         6006     6006           
  Misses        887      887           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit c3ce5dd into master Nov 30, 2022
@bednar bednar deleted the fix-duplicated-http-header branch November 30, 2022 13:45
@bednar bednar added this to the 4.8.0 milestone Nov 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem fetching Dashboard(s). Error: An item with the same key has already been added. Key: Server
3 participants