Skip to content

feat: #560 disable console log #590

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 11 commits into from
Nov 7, 2023
Merged

feat: #560 disable console log #590

merged 11 commits into from
Nov 7, 2023

Conversation

Sciator
Copy link
Contributor

@Sciator Sciator commented Nov 3, 2023

Closes #560

Proposed Changes

Allows disable Trace verbose messages

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@Sciator Sciator linked an issue Nov 3, 2023 that may be closed by this pull request
@Sciator Sciator changed the title #560 disable console log feat: #560 disable console log Nov 3, 2023
@Sciator Sciator marked this pull request as ready for review November 3, 2023 11:08
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question regarding the tracing configuration: Is it possible to selectively disable log messages originating from the WriteApi? For instance, messages like the ones shown in the screenshot below can be quite distracting:

image

However, other messages may still be valuable for our customers. The customer looking for a way to suppress only the WriteApi messages without affecting the rest. Is it possible?

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR 👍. We're nearly there. Could you please rename the CategoryTraceFilter.cs file to InfluxDBTraceFilter.cs and address the latest minor requirements:

@Sciator Sciator force-pushed the 560-disable-console-log branch 2 times, most recently from 392751f to 3d82f47 Compare November 7, 2023 08:00
@Sciator Sciator requested a review from bednar November 7, 2023 08:26
@Sciator Sciator force-pushed the 560-disable-console-log branch from 3d82f47 to 6343308 Compare November 7, 2023 09:05
@bednar bednar added this to the 4.14.0 milestone Nov 7, 2023
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bednar bednar merged commit 8e6daf3 into master Nov 7, 2023
@bednar bednar deleted the 560-disable-console-log branch November 7, 2023 09:14
@bednar bednar mentioned this pull request Nov 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Console Log
2 participants