Skip to content

fix: write buffer uses correct flush interval and batch size under heavy load #69

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 3, 2020

part of #68

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@bednar bednar added this to the 1.7.0 milestone Apr 3, 2020
@bednar bednar self-assigned this Apr 3, 2020
@bednar bednar added the bug Something isn't working label Apr 3, 2020
@codecov-io
Copy link

codecov-io commented Apr 3, 2020

Codecov Report

Merging #69 into master will increase coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   15.93%   16.02%   +0.09%     
==========================================
  Files          47       47              
  Lines        4593     4623      +30     
  Branches      144      224      +80     
==========================================
+ Hits          732      741       +9     
- Misses       3861     3862       +1     
- Partials        0       20      +20     
Impacted Files Coverage Δ
Client/WriteApi.cs 0.00% <0.00%> (ø)
Client.Core/Arguments.cs 16.00% <0.00%> (-8.00%) ⬇️
Client.Core.Test/AbstractMockServerTest.cs 96.42% <0.00%> (-3.58%) ⬇️
Client.Core/Flux/Internal/FluxResultMapper.cs 41.12% <0.00%> (-2.81%) ⬇️
Client.Core/Internal/LoggingHandler.cs 24.39% <0.00%> (-2.44%) ⬇️
Client.Core/Flux/Domain/FluxRecord.cs 81.81% <0.00%> (-2.28%) ⬇️
Client.Core/Flux/Internal/FluxCsvParser.cs 93.92% <0.00%> (-1.66%) ⬇️
Client.Core.Test/AbstractTest.cs 73.13% <0.00%> (-1.50%) ⬇️
Client.Legacy/FluxClient.cs 98.31% <0.00%> (-0.57%) ⬇️
Client.Core/Exceptions/InfluxException.cs 87.75% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125ce33...0fc96e8. Read the comment docs.

@bednar bednar merged commit 3317c8c into master Apr 3, 2020
@bednar bednar deleted the fix/buffer-under-heavy-load branch April 3, 2020 12:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants