Skip to content

fix: parsing error response for queries #83

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 20, 2020

Closes #80

The error response for queries is encoded as a stream not as a "simple" string.

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@bednar bednar added the bug Something isn't working label Apr 20, 2020
@bednar bednar added this to the 1.8.0 milestone Apr 20, 2020
@codecov-io
Copy link

codecov-io commented Apr 20, 2020

Codecov Report

Merging #83 into master will increase coverage by 0.40%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   15.96%   16.37%   +0.40%     
==========================================
  Files          47       47              
  Lines        4641     4666      +25     
  Branches      224      227       +3     
==========================================
+ Hits          741      764      +23     
- Misses       3880     3882       +2     
  Partials       20       20              
Impacted Files Coverage Δ
Client/InfluxDBClient.cs 0.00% <0.00%> (ø)
Client/WriteApi.cs 0.00% <0.00%> (ø)
Client.Core/Exceptions/InfluxException.cs 89.18% <87.09%> (+1.43%) ⬆️
Client.Core/Internal/AbstractQueryClient.cs 76.81% <100.00%> (ø)
Client.Legacy/FluxClient.cs 98.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5433d79...f29b42f. Read the comment docs.

@bednar bednar merged commit 178277c into master Apr 20, 2020
@bednar bednar deleted the fix/parsing-error-from-1.x branch April 20, 2020 11:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of handling HTTP Forbidden (403)
2 participants