Skip to content
This repository has been archived by the owner on Jul 18, 2023. It is now read-only.

Add compression to LineProtocolClient #81

Merged
merged 8 commits into from
Jun 4, 2020
Merged

Conversation

stmax82
Copy link
Contributor

@stmax82 stmax82 commented Feb 11, 2020

I added gzip compression to HTTP POST requests.

Quick tests have shown that it reduces Content-Length down to 50% (for short single point requests) and down to <10% (for large multi-point requests).

Compression can be enabled using an optional parameter of the LineProtocolClient constructor.
Default is off so the behavior should be the same as before.

@stmax82
Copy link
Contributor Author

stmax82 commented May 29, 2020

@bednar @nblumhardt could we get updates for the open pull requests please?

@nblumhardt
Copy link
Contributor

@stmax82 I'm no longer a maintainer, here, sorry.

@bednar bednar self-requested a review June 2, 2020 06:34
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stmax82,

thanks for your PR.

Could you please update CHANGELOG.md and add unit tests to cover your changes?

Regards

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@stmax82
Copy link
Contributor Author

stmax82 commented Jun 3, 2020

Hi @bednar,

Could you please update CHANGELOG.md and add unit tests to cover your changes?

done - I updated the changelog and added a few tests for the LineProtocolClient with and without compression.

@stmax82 stmax82 requested a review from bednar June 3, 2020 20:35
@stmax82 stmax82 changed the title Compression Add compression to LineProtocolClient Jun 3, 2020
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Build influxdb-csharp 17 completed (commit aad4b8024e by @bednar)

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar added this to the 1.2.0 milestone Jun 4, 2020
@bednar bednar merged commit 290c120 into influxdata:dev Jun 4, 2020
@bednar
Copy link
Contributor

bednar commented Jun 4, 2020

Hi @stmax82 ,

The issue is fixed in 1.2.0 milestone.

If you would like to use a preview version use our nightly build: InfluxDB.LineProtocol 1.2.0-dev-00018.

Regards

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants