Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(outputs.kafka): Option to add metric name as record header #15721

Closed
Mrflatt opened this issue Aug 8, 2024 · 3 comments · Fixed by #15722
Closed

feat(outputs.kafka): Option to add metric name as record header #15721

Mrflatt opened this issue Aug 8, 2024 · 3 comments · Fixed by #15722
Labels
area/kafka feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue

Comments

@Mrflatt
Copy link
Contributor

Mrflatt commented Aug 8, 2024

Use Case

Option to add metric name as record header, which allows consumer to check if record should be skipped or processed. Record value is deserialized only when it's needed to be processed. Our usecase have around a million messages per second and not every message is currently processed (every message is deserialized and name field is checked)

Expected behavior

Producer adds header when option is set. Header key is specified by user and value is metric name

Actual behavior

Not implemented, opening pr

Additional info

No response

@Mrflatt Mrflatt added the feature request Requests for new plugin and for new features to existing plugins label Aug 8, 2024
@powersj
Copy link
Contributor

powersj commented Aug 8, 2024

Hi,

allows consumer to check if record should be skipped or processed

When you say skipped, does that mean dropped? Is there a reason to not do this filtering at the telegraf level with metric filtering?

@powersj powersj added the waiting for response waiting for response from contributor label Aug 8, 2024
@Mrflatt
Copy link
Contributor Author

Mrflatt commented Aug 8, 2024

Hi,

allows consumer to check if record should be skipped or processed

When you say skipped, does that mean dropped? Is there a reason to not do this filtering at the telegraf level with metric filtering?

We currently collect pm data from network devices using gnmi input plugin. All the data ends in shared kafka cluster, where users can use it for alerts, link traffic data for ai/ml stuff, checking fiber rx/rx leves, etc.
All the data is needed but not with every party involved :D

Edit. We could use topic_suffix, but it doesn't cover all the usecases currently

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Aug 8, 2024
@powersj
Copy link
Contributor

powersj commented Aug 8, 2024

All the data is needed but not with every party involved :D

ok thanks for the further background. Happy to see a PR that exposes the option. This would need to be opt-in of course.

@powersj powersj added help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue area/kafka labels Aug 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/kafka feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants