Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(outputs.kafka): Option to add metric name as record header #15722

Merged
merged 1 commit into from
Aug 13, 2024
Merged

feat(outputs.kafka): Option to add metric name as record header #15722

merged 1 commit into from
Aug 13, 2024

Conversation

Mrflatt
Copy link
Contributor

@Mrflatt Mrflatt commented Aug 8, 2024

Summary

Adds metric name as kafka record header. Allows checking metric name before consumer will deserialize record.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15721

@telegraf-tiger telegraf-tiger bot added area/kafka feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Aug 8, 2024
@Mrflatt Mrflatt force-pushed the feat/kafka-header branch from 20cdeb5 to f430c6d Compare August 9, 2024 19:19
srebhan
srebhan reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mrflatt for your contribution! I do have two small comments...

@srebhan srebhan self-assigned this Aug 12, 2024
@Mrflatt Mrflatt force-pushed the feat/kafka-header branch from f430c6d to 1616e8e Compare August 12, 2024 10:15
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Mrflatt!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 13, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Aug 13, 2024
@powersj powersj merged commit fc19891 into influxdata:master Aug 13, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Aug 13, 2024
@Mrflatt
Copy link
Contributor Author

Mrflatt commented Aug 13, 2024

Thanks for your contribution @Mrflatt!

Thanks for fast review!

@BrewTestBot BrewTestBot mentioned this pull request Sep 9, 2024
Merged
@Mrflatt Mrflatt deleted the feat/kafka-header branch September 29, 2024 12:17
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@Mrflatt @asaharn
feat(outputs.kafka): Option to add metric name as record header (infl…
81c5b91 
…uxdata#15722)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

@DStrand1 DStrand1

Labels
area/kafka feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.

feat(outputs.kafka): Option to add metric name as record header
4 participants
@Mrflatt @powersj @srebhan @DStrand1