Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: added metrics for member and replica-set avg health of MongoDB … #11516

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

svenburkard
Copy link
Contributor

…input plugin

  • make check
  • make check-deps
  • make test
  • make docs
  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format

resolves #11515

Added metrics for member and replica-set average health of MongoDB input plugin.
With this additional Telegraf metrics, you have all needed data ready to build monitoring alerts on unhealthy MongoDB replica-set events.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 18, 2022
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @svenburkard, thanks for your contribution. The code looks quite nice already, I only have two minor comments. Please have a look!

@srebhan srebhan self-assigned this Jul 19, 2022
@srebhan srebhan added area/mongodb plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 19, 2022
@telegraf-tiger
Copy link
Contributor

@svenburkard
Copy link
Contributor Author

Hi @srebhan, thanks for your feedback. The suggested changes have been added with a fresh rebase of the current master and the Lint CI job seems to be happy now :)

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution @svenburkard!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 20, 2022
@svenburkard
Copy link
Contributor Author

Nice, you are welcome!

@powersj powersj merged commit 46f059e into influxdata:master Jul 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/mongodb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.mongodb : adding metrics for member and replica-set avg health
3 participants