Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(inputs.tail): Allow handling of quoted strings spanning multiple lines #11762

Merged
merged 10 commits into from
Nov 15, 2022

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Sep 5, 2022

This PR allows to handle files with quoted strings spanning multiple lines, e.g.

1660819827425,12,Get Homepage264 /api/version,200,OK,DR 4-4,text,true,,896,787,6,16,https://abc.test.com/api/version,12,0,0,SP-1

1660819827419,17,LoginB3 PLANs /auth/callback,500,Internal Server Error,StoreReplenishment 3-1,text,false,"Test failed: code expected to equal /

****** received  : [[[5]]]00

****** comparison: [[[2]]]00

/",344,980,2,16,https://abc.test.com/,17,0,0,SP-1

1660819827046,391,Submit Login,,"Number of samples in transaction : 4, number of failing samples : 1",Store 3-1,,false,,4838,7608,2,16,null,388,2,0,SP-1
1660819826877,558,Do Login Support,,"Number of samples in transaction : 8, number of failing samples : 1",Store 3-1,,false,,12068,10167,2,16,null,440,4,50,SP-1
1660819827419,26,Get Homepage278 /api/session,200,OK,DR 4-2,text,true,,2267,893,6,16,https://abc.test.com/api/session,26,0,0,SP-1
1660819827445,15,Get Homepage273 /api/scenarios,200,OK,DR 4-2,text,true,,888,803,6,16,https://abc.test.com/api/scenarios,15,0,0,SP-1
1660819827349,115,Get Homepage261 /api/reports,200,OK,SF 1-1,text,true,,36552,797,1,16,https://abc.test.com/api/reports,115,0,0,SP-1

(taken from Slack).

The feature is disabled by default and has to be enabled using a new quotation option for inputs.tail.multiline.

@srebhan srebhan added area/tail plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Sep 5, 2022
@srebhan srebhan changed the title feat (inputs.tail): Allow handling of quoted strings spanning multiple lines feat(inputs.tail): Allow handling of quoted strings spanning multiple lines Sep 5, 2022
@powersj
Copy link
Contributor

powersj commented Oct 3, 2022

@srebhan I know we chatted about this one in standup, what did we decide as far as the way forward?

@srebhan
Copy link
Member Author

srebhan commented Nov 8, 2022

@powersj we agreed on specifying the quotation quotes explicitly, which is done by the last update. :-)

@srebhan srebhan requested a review from Hipska November 8, 2022 12:10
@srebhan srebhan requested a review from Hipska November 8, 2022 15:43
@Hipska Hipska added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 8, 2022
@telegraf-tiger
Copy link
Contributor

@Hipska Hipska requested a review from powersj November 15, 2022 10:35
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional error condition tests!

@srebhan srebhan merged commit 9acbf23 into influxdata:master Nov 15, 2022
@srebhan srebhan deleted the debug branch November 15, 2022 17:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/tail feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants