Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(output.datadog): log response in case of non 2XX response from API #12201

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

neelayu
Copy link
Contributor

@neelayu neelayu commented Nov 8, 2022

Required for all PRs

resolves: NA

Add a debug log to print the response string obtained from API in case of a non 2XX status.

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Nov 8, 2022

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the chore label Nov 8, 2022
@neelayu
Copy link
Contributor Author

neelayu commented Nov 8, 2022

!signed-cla

@powersj powersj added the waiting for response waiting for response from contributor label Nov 8, 2022
@powersj powersj added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed waiting for response waiting for response from contributor labels Nov 16, 2022
@powersj powersj changed the title chore: log response in case of non 2XX response from API fix(output.datadog): log response in case of non 2XX response from API Nov 16, 2022
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution @neelayu!

@srebhan srebhan merged commit 6f407c5 into influxdata:master Nov 21, 2022
powersj pushed a commit that referenced this pull request Nov 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants