Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(inputs.mongodb): Fix connection leak #12330

Merged
merged 1 commit into from
Dec 9, 2022
Merged

fix(inputs.mongodb): Fix connection leak #12330

merged 1 commit into from
Dec 9, 2022

Conversation

zhiyuan-mojie
Copy link
Contributor

@zhiyuan-mojie zhiyuan-mojie commented Dec 5, 2022 •
edited
Loading

Required for all PRs

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in [conventional commit format]

resolves #12336
Fixed an mongo connections leak triggered by auto reload config mechanism.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Dec 5, 2022
@powersj
Copy link
Contributor

powersj commented Dec 5, 2022

Thanks for the PR! Can you fix the lint issue?

@powersj powersj added the waiting for response waiting for response from contributor label Dec 5, 2022
@zhiyuan-mojie zhiyuan-mojie force-pushed the master branch 2 times, most recently from d0abcac to cb354f8 Compare December 6, 2022 03:23
powersj
powersj approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to put up a PR!

@powersj powersj added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed waiting for response waiting for response from contributor labels Dec 8, 2022
srebhan
srebhan reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhiyuan-mojie for contributing this nice fix! I do have one suggestion to log errors though... What do you think?

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 9, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @zhiyuan-mojie!

@srebhan srebhan changed the title fix: connection leak lead to full connections of mongo triggered by a… fix(inputs.mongodb): Fix connection leak Dec 9, 2022
@srebhan srebhan added area/mongodb plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 9, 2022
@srebhan srebhan merged commit 375e089 into influxdata:master Dec 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/mongodb fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connections leak triggered by auto reload config mechanism
3 participants
@zhiyuan-mojie @powersj @srebhan