-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(inputs.prometheus): Set the timeout for slow running API endpoints correctly #12559
fix(inputs.prometheus): Set the timeout for slow running API endpoints correctly #12559
Conversation
5412af9
to
3a4836c
Compare
3a4836c
to
746fb72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking this down and putting up a PR! Two comments inline
c9fdcae
to
4b1b74f
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the nice fix @ZPascal!
resolves #12485
Description:
The issue was related to a missed timeout configuration inside http client to establish a connection to an slow responsed Promtheus endpoint.