Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(inputs.azure_monitor): Add client options parameter #15519

Merged
merged 2 commits into from
Aug 7, 2024
Merged

feat(inputs.azure_monitor): Add client options parameter #15519

merged 2 commits into from
Aug 7, 2024

Conversation

ZPascal
Copy link
Contributor

@ZPascal ZPascal commented Jun 17, 2024 •
edited
Loading

Summary

The PR adds the Azure Client option parameter to also support the Azure sovereign cloud regions.

Checklist

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 17, 2024
@ZPascal ZPascal marked this pull request as ready for review June 17, 2024 14:16
@ZPascal ZPascal force-pushed the adjust-the-azure-monitor branch 4 times, most recently from 923f63a to 8f1f3ba Compare August 5, 2024 19:23
@ZPascal
Copy link
Contributor Author

ZPascal commented Aug 5, 2024

@srebhan & @powersj Can you please take a look?

powersj
powersj reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving this upstream.

@powersj powersj self-assigned this Aug 5, 2024
@ZPascal ZPascal force-pushed the adjust-the-azure-monitor branch from 8f1f3ba to aa796b5 Compare August 5, 2024 21:55
@ZPascal ZPascal requested a review from powersj August 5, 2024 21:55
powersj
powersj reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small item and then I can mark this ready for final review. Essentially, we watch the switch statement to throw an error if an unknown option value is recevied.

@ZPascal ZPascal force-pushed the adjust-the-azure-monitor branch from e23116d to 14aa8c6 Compare August 6, 2024 18:43
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 6, 2024
@powersj powersj assigned srebhan, dgnorton and DStrand1 and unassigned dgnorton and powersj Aug 6, 2024
@srebhan srebhan changed the title feat: Add the Azure client options parameter feat(inputs.azure_monitor): Add client options parameter Aug 7, 2024
@telegraf-tiger telegraf-tiger bot added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Aug 7, 2024
srebhan
srebhan reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZPascal thanks for the PR! I do have just one small comment and a request to resolve the conflict...

@srebhan srebhan added the area/azure Azure plugins including eventhub_consumer, azure_storage_queue, azure_monitor label Aug 7, 2024
@ZPascal ZPascal force-pushed the adjust-the-azure-monitor branch from a577b15 to 6ad4f7f Compare August 7, 2024 15:50
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 7, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan merged commit ad55f42 into influxdata:master Aug 7, 2024
27 checks passed
@ZPascal ZPascal deleted the adjust-the-azure-monitor branch August 7, 2024 19:52
@github-actions github-actions bot added this to the v1.32.0 milestone Aug 7, 2024
@ZPascal
Copy link
Contributor Author

ZPascal commented Aug 7, 2024 •
edited
Loading

@srebhan Thanks for merging the PR. Will the feature be released with the next feature release in September?

@srebhan
Copy link
Member

srebhan commented Aug 8, 2024

@ZPascal very likely. You can see it is planned for v1.32.0 looking at the "Milestone" item in the PR. v1.32.0 is scheduled for 9th of September...

@ZPascal
Copy link
Contributor Author

ZPascal commented Aug 8, 2024

@srebhan Thank you for the information.

@BrewTestBot BrewTestBot mentioned this pull request Sep 9, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/azure Azure plugins including eventhub_consumer, azure_storage_queue, azure_monitor feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ZPascal @srebhan @powersj @dgnorton @DStrand1