Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(inputs.amd_rocm_smi): Parse newer ROCm versions #15628

Merged
merged 1 commit into from
Jul 19, 2024
Merged

feat(inputs.amd_rocm_smi): Parse newer ROCm versions #15628

merged 1 commit into from
Jul 19, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jul 16, 2024

Summary

  1. Parse the DeviceID field similar to the existing GPU ID field
  2. Parse new GPU memory allocated field similar to the existing GPU memory use field
  3. Add the card series, model, and vendor as string fields
  4. Add the various clock speed fields for display, fabric, and system.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15620

@powersj
feat(inputs.amd_rocm_smi): Parse newer ROCm versions
ec61070 
1. Newer versions of ROCm seem to report the GPU ID via the DeviceID field.
   This tries both.
2. Add the card series, model, and vendor as string fields
3. Parse new GPU memory allocated field, similar to the existing GPU memory use
   field.
4. Start reporting the various clock speed fields for display, fabric, and system.

fixes: influxdata#15620
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 16, 2024
@powersj powersj mentioned this pull request Jul 16, 2024
Closed
@powersj powersj self-assigned this Jul 16, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 18, 2024
@powersj powersj assigned DStrand1 and srebhan and unassigned powersj Jul 18, 2024
@DStrand1 DStrand1 removed their assignment Jul 18, 2024
srebhan
srebhan approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan merged commit a6270b7 into influxdata:master Jul 19, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Jul 19, 2024
@BrewTestBot BrewTestBot mentioned this pull request Sep 9, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@DStrand1 DStrand1 DStrand1 approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.

amd_rocm_smi plugin missing field and tag
3 participants
@powersj @srebhan @DStrand1