-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(inputs.mongodb): Do not dereference nil pointer if gathering database stats fails #16310
fix(inputs.mongodb): Do not dereference nil pointer if gathering database stats fails #16310
Conversation
… pointer for db causing subsequent dereference failure Occasionally happens on our clusters, like every 2-4 weeks. The error message has never been seen as it gets logged at Debug level, which has also been changed to Error in this commit.
@dkhamitov could you please open an issue additional to this PR describing the issue? This will ease finding this solution for other users... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your fix @dkhamitov! I do have one small comment in the code...
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dkhamitov!
Summary
Occasionally happens on our clusters, like every 2-4 weeks. The error message has never been seen as it gets logged at Debug level, which has also been changed to Error in this commit. Please let me know if the log level update is not an issue as I can see some errors are only logged at Debug level.
Checklist
Related issues
Resolves #16329