Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(inputs.x509_cert): Add config to left-pad serial number to 128-bits #16447

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

DStrand1
Copy link
Member

Summary

Fixes leading zeroes being trimmed on x509 certificate serial numbers

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16418

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 29, 2025
@DStrand1 DStrand1 self-assigned this Jan 29, 2025
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DStrand1! One comment...

@DStrand1 DStrand1 changed the title fix(inputs.x509_cert): Fix serial number leading zeroes trimmed fix(inputs.x509_cert): Add config to left-pad serial number to 128-bits Jan 31, 2025
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DStrand1! Is this ready for merging?

@DStrand1
Copy link
Member Author

DStrand1 commented Feb 4, 2025

@srebhan Yep! Forgot to assign it to you and mark ready for final review yesterday

@DStrand1 DStrand1 merged commit 7f1c5d3 into influxdata:master Feb 4, 2025
29 checks passed
@github-actions github-actions bot added this to the v1.33.2 milestone Feb 4, 2025
srebhan pushed a commit that referenced this pull request Feb 10, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.x509_cert trims leading 0 for serial_number
2 participants