Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(agent): Set godebug x509negativeserial=1 as a workaround #16489

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

DStrand1
Copy link
Member

@DStrand1 DStrand1 commented Feb 6, 2025

Summary

Works around an issue with negative and oversize x509 certificate serial numbers to restore behavior from before Go 1.23. Long term I am communicating with the Go team to see if there is a better solution

Checklist

  • No AI generated code was used in this PR

Related issues

Related to #16309

@DStrand1 DStrand1 self-assigned this Feb 6, 2025
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Feb 6, 2025
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @DStrand1!

@srebhan srebhan added area/agent go Pull requests that update Go code ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Feb 10, 2025
@srebhan srebhan merged commit 5f4ee87 into influxdata:master Feb 10, 2025
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.33.2 milestone Feb 10, 2025
srebhan pushed a commit that referenced this pull request Feb 10, 2025
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Mar 10, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/agent fix pr to fix corresponding bug go Pull requests that update Go code ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants