feat(outputs.nats): Add option to use async Jetstream publish #16582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
feat
kfollesdal
force-pushed
the
nats-publish-async-jetstream
branch
2 times, most recently
from
90a09ef to
4cd7f12
Compare
|
Let's merge #16570 first and then rebase this PR. In any case this looks good to me already. |
kfollesdal
force-pushed
the
nats-publish-async-jetstream
branch
from
4cd7f12 to
3f0c6e9
Compare
To achieve higher throughput, add an option to use asynchronous publishing. In benchmarks, asynchronous publishing is significantly faster—up to 16 times in one test. This improvement comes from not having to wait for individual publish acknowledgments, allowing all acknowledgments to be checked at once.
kfollesdal
force-pushed
the
nats-publish-async-jetstream
branch
from
84df24c to
fa4eb1d
Compare
neelayu
reviewed
Mar 11, 2025
plugins/outputs/nats/nats.go
Outdated
| return fmt.Errorf("publish acknowledgement is an error: %w (retrying)", err) | ||
| } | ||
| } | ||
| case <-time.After(5 * time.Second): |
There was a problem hiding this comment.
@kfollesdal @srebhan Can we also make this configurable?
this can come under async table in TOML config or as a standalone field.
Add option async_ack_timeout to controll timeout for waiting on ack from async publish.
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves #16581 by adding option to use async jetstream publish. "Make" up for loose of performance when changing to sync jetstream publisher vs core.
Checklist
Related issues
resolves #16581
based on #16570