Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: multiorg Global Header #4939

Merged
merged 72 commits into from
Jul 7, 2022
Merged

Conversation

ChitlangeSahas
Copy link
Contributor

@ChitlangeSahas ChitlangeSahas commented Jun 30, 2022

Closes #4051
Closes #4047

Co Authored by @wdoconnell

Multi-org epic requires a global header that includes a searchable switch account and switch org menu, which this feature implements. The 'user'-related portion of the header component will be completed alongside #4049

This feature is behind the multiOrg and quartzIdentity feature flags, and will not appear in the app unless those flags are enabled.

Screen.Recording.2022-07-01.at.12.18.54.PM.mov

To test generation of arbitrarily large collections of accounts/organizations, a mock can be commented into the file so that tests can be run without provisioning thousands of quartz orgs or accounts.

This has been tested both with mock data using remocal, as well as with non-mocked data with quartz-remocal. When using actual quartz data, the 'Settings,' 'Billing', and 'Members' buttons also redirect the user to the corresponding pages in their currently-selected account or organization.

Screen.Recording.2022-07-01.at.2.09.45.PM.mov

There may be some minor additional tweaks (e.g., removing superfluous code) once parallel changes are merged to clockface.

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

ChitlangeSahas and others added 30 commits June 21, 2022 11:01
@wdoconnell
Copy link
Contributor

On Tuesday, let's circle up w/ Bucky re whether he's on board with adding the random org/account generator. It's useful for demonstration purposes so that we don't have duplicate org/account names when we're testing the component for large account/org values, but maybe we don't need that many lines - that file is twice the size of the other globalheader files.

@ChitlangeSahas ChitlangeSahas requested a review from a team July 6, 2022 15:54
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work, have a few suggestions here.

Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@wdoconnell wdoconnell merged commit 47a491e into master Jul 7, 2022
@wdoconnell wdoconnell deleted the sprint13_sahas_bill_multiorg_header branch July 7, 2022 20:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi Org - Switch Org Multi Org - Switch Account
3 participants